Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ruff preview rule RUF046 #687

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jan 10, 2025

RUF046 Value being casted is already an integer

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (5502dc8) to head (d718988).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          62       62           
  Lines        2752     2752           
=======================================
  Hits         2747     2747           
  Misses          5        5           
Files with missing lines Coverage Δ
numcodecs/quantize.py 100.00% <100.00%> (ø)

RUF046 Value being casted is already an integer
@dstansby dstansby merged commit 0162bb8 into zarr-developers:main Jan 17, 2025
18 of 26 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the RUF046 branch January 18, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants