Last batch of ruff rules #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
- Coverage 99.92% 99.92% -0.01%
==========================================
Files 62 62
Lines 2761 2747 -14
==========================================
- Hits 2759 2745 -14
Misses 2 2
|
DimitriPapadopoulos
force-pushed
the
final_ruff
branch
3 times, most recently
from
5f3086a to
bec947e
Compare
DimitriPapadopoulos
force-pushed
the
final_ruff
branch
from
bec947e to
80cec26
Compare
Disable the rule directly in the incriminated test file.
UP007 Use `X | Y` for type annotations
DimitriPapadopoulos
force-pushed
the
final_ruff
branch
from
80cec26 to
1f1d2a1
Compare
The directories to consider when resolving first- vs. third-party imports.
The linter includes some rules that, when enabled, can cause conflicts with the formatter, leading to unexpected behavior. None None of these rules are included in Ruff's default configuration. However, since we have enabled some relevant rule sets, we disable these rules.
SIM105 Use `contextlib.suppress(ImportError)` instead of `try`-`except`-`pass`
TRY301 Abstract `raise` to an inner function
B904 Within an `except` clause, raise exceptions with `raise ... from err`
or `raise ... from None` to distinguish them from errors in exception
handling
B028 No explicit `stacklevel` keyword argument found
RUF022 `__all__` is not sorted
DimitriPapadopoulos
force-pushed
the
final_ruff
branch
from
1f1d2a1 to
396b68c
Compare
dstansby
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last batch of ruff rules, upgrade to ruff 0.8.0
TODO: