Apply and enforce more ruff rules (#594)

* Deprecate a couple ruff/pyupgrade rules (UP)

* Enforce ruff/flake8-pytest-style rules (PT)

* Apply ruff/flake8-pytest-style rule PT006

PT006 Wrong type passed to first argument of `@pytest.mark.parametrize`; expected `tuple`

* Apply ruff/flake8-pytest-style rule PT007

PT007 Wrong values type in `@pytest.mark.parametrize` expected `list` of `tuple`

* Enforce ruff/flake8-bugbear rules (B)

* Apply ruff/flake8-executable rule EXE001

EXE001 Shebang is present but file is not executable

* Enforce ruff/pygrep-hooks rules (PGH)

* Apply ruff/flake8-simplify rule SIM102

SIM102 Use a single `if` statement instead of nested `if` statements

* Apply ruff/flake8-simplify rule SIM105

SIM105 Use `contextlib.suppress(ImportError)` instead of `try`-`except`-`pass`

* Apply ruff/flake8-raise rule RSE102

RSE102 Unnecessary parentheses on raised exception

* Enforce ruff/flake8-raise rules (RSE)

numcodecs/lzma.py

@@ -1,11 +1,11 @@
+import contextlib
+
 _lzma = None
 try:
     import lzma as _lzma
 except ImportError:  # pragma: no cover
-    try:
+    with contextlib.suppress(ImportError):
         from backports import lzma as _lzma
-    except ImportError:
-        pass
 
 
 if _lzma:

numcodecs/registry.py

@@ -42,11 +42,10 @@ def get_codec(config):
     config = dict(config)
     codec_id = config.pop('id', None)
     cls = codec_registry.get(codec_id)
-    if cls is None:
-        if codec_id in entries:
-            logger.debug("Auto loading codec '%s' from entrypoint", codec_id)
-            cls = entries[codec_id].load()
-            register_codec(cls, codec_id=codec_id)
+    if cls is None and codec_id in entries:
+        logger.debug("Auto loading codec '%s' from entrypoint", codec_id)
+        cls = entries[codec_id].load()
+        register_codec(cls, codec_id=codec_id)
     if cls:
         return cls.from_config(config)
     raise ValueError(f'codec not available: {codec_id!r}')

numcodecs/tests/test_blosc.py

@@ -133,7 +133,7 @@ def test_compress_blocksize_default(use_threads):
     assert blocksize > 0
 
 
-@pytest.mark.parametrize('bs', (2**7, 2**8))
+@pytest.mark.parametrize('bs', [2**7, 2**8])
 def test_compress_blocksize(use_threads, bs):
     arr = np.arange(1000, dtype='i4')
 
@@ -225,7 +225,7 @@ def _decode_worker(enc):
     return data
 
 
-@pytest.mark.parametrize('pool', (Pool, ThreadPool))
+@pytest.mark.parametrize('pool', [Pool, ThreadPool])
 def test_multiprocessing(use_threads, pool):
     data = np.arange(1000000)
     enc = _encode_worker(data)

numcodecs/tests/test_json.py

@@ -59,7 +59,7 @@ def test_backwards_compatibility():
 
 
 @pytest.mark.parametrize(
-    "input_data, dtype",
+    ('input_data', 'dtype'),
     [
         ([0, 1], None),
         ([[0, 1], [2, 3]], None),

numcodecs/tests/test_msgpacks.py

@@ -56,7 +56,7 @@ def test_backwards_compatibility():
 
 
 @pytest.mark.parametrize(
-    "input_data, dtype",
+    ("input_data", "dtype"),
     [
         ([0, 1], None),
         ([[0, 1], [2, 3]], None),

numcodecs/tests/test_shuffle.py

@@ -89,7 +89,7 @@ def _decode_worker(enc):
     return data
 
 
-@pytest.mark.parametrize('pool', (Pool, ThreadPool))
+@pytest.mark.parametrize('pool', [Pool, ThreadPool])
 def test_multiprocessing(pool):
     data = np.arange(1000000)
     enc = _encode_worker(data)

pyproject.toml

@@ -137,8 +137,28 @@ environment = { DISABLE_NUMCODECS_AVX2=1, DISABLE_NUMCODECS_SSE2=1 }
 line-length = 100
 
 [tool.ruff.lint]
-extend-select = [ "B", "I", "RUF", "UP" ]
-ignore = [ "RUF001", "UP007" ]
+extend-select = [
+    "B",
+    "I",
+    "PGH",
+    "PT",
+    "RSE",
+    "RUF",
+    "UP",
+]
+ignore = [
+    "B028",
+    "B904",
+    "PT001",
+    "PT004",  # deprecated
+    "PT005",  # deprecated
+    "PT011",
+    "PT012",
+	"RUF001",
+    "UP007",
+    "UP027",  # deprecated
+    "UP038",  # https://github.com/astral-sh/ruff/issues/7871
+]
 
 [tool.ruff.format]
 quote-style = "preserve"

setup.py

@@ -333,14 +333,14 @@ def run(self):
             build_ext.run(self)
         except PlatformError as e:
             error(e)
-            raise BuildFailed() from e
+            raise BuildFailed from e
 
     def build_extension(self, ext):
         try:
             build_ext.build_extension(self, ext)
         except ext_errors as e:
             error(e)
-            raise BuildFailed() from e
+            raise BuildFailed from e
 
 
 class Sclean(clean):