Align HDF reader CF _FillValue with Zarr v3 semantics #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sharkinsspatial
commented
Feb 4, 2025
sharkinsspatial
commented
- Closes TypeError: ufunc 'isnan' not supported for the input types #356
- Tests added
- Tests passing
sharkinsspatial
temporarily deployed
to
test-release
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
- Coverage 88.74% 88.63% -0.12%
==========================================
Files 28 28
Lines 1742 1751 +9
==========================================
+ Hits 1546 1552 +6
- Misses 196 199 +3
|
sharkinsspatial
temporarily deployed
to
test-release
GitHub Actions
Inactive
sharkinsspatial
force-pushed
the
fix/fill_value
branch
from
95055c5 to
37906b0
Compare
sharkinsspatial
temporarily deployed
to
test-release
GitHub Actions
Inactive
12 tasks
sharkinsspatial
temporarily deployed
to
test-release
GitHub Actions
Inactive
sharkinsspatial
force-pushed
the
fix/fill_value
branch
from
e25ca39 to
e350cb1
Compare
sharkinsspatial
temporarily deployed
to
test-release
GitHub Actions
Inactive
sharkinsspatial
changed the title
| An h5py group or dataset. | ||
| """ | ||
| fillvalue = None | ||
| for n, v in h5obj.attrs.items(): |
There was a problem hiding this comment.
Is there a way to integrate this so we don't have to loop through attrs twice? Just noticing we also loop through attrs in _extract_attrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.