Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: avoid flake in test external #3432

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

AustinAbro321
Copy link
Contributor

Description

There is a flake we often get in test external #3194 relating to a broken Zarf cache. Likely, this will not get resolved until we either stop pulling packages in parallel (unlikely as it would make pulling signifigantly slower), or move away from crane (planned but will take time). Adding this in as a band aid to avoid flakes

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 24, 2025 15:34
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 81cbba2
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6793b321c09bc300082e7db6

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/sbom/catalog.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager/sbom/catalog.go 0.00% <0.00%> (ø)

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit c592273 Jan 24, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the band-aid-external-flake branch January 24, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants