Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unexport cmd functions besides NewZarfCommand #3421

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Jan 22, 2025

Description

This will unexport all commands besides NewZarfCommand. This keeps the surface area of breaking changes small, while giving users a while to directly embed Zarf with Cobra.

This flattens the src/cmd package as well which enables unexporting functions, and makes the structure simpler all around. We no longer need a separate common package to avoid import cycles.

Related Issue

Fixes #2765 (Technically the issue could have already been closed, it's more intentional this time though)

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit f7ab524
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67914cecb7db41000813fff5

Copy link

codecov bot commented Jan 22, 2025

@AustinAbro321 AustinAbro321 marked this pull request as ready for review January 22, 2025 19:56
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 22, 2025 19:56
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 30b79f4 Jan 22, 2025
38 checks passed
@AustinAbro321 AustinAbro321 deleted the unexport-cmd branch January 22, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for proper embedding of Zarf CLI
2 participants