Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextTemplate type is no longer public #2395

Closed
UncleGedd opened this issue Mar 22, 2024 · 1 comment · Fixed by #2414
Closed

TextTemplate type is no longer public #2395

UncleGedd opened this issue Mar 22, 2024 · 1 comment · Fixed by #2414
Labels
possible-bug 🐛

Comments

@UncleGedd
Copy link
Contributor

Description

When upgrading Zarf to 0.32.6, it looks like the TextTemplate type which was formerly in utils has been moved to internal/packager/template. This breaks Zarf library code (ie. maru-runner) that is using the TextTemplate type
@UncleGedd
Copy link
Contributor Author

Same for ReplaceTextTemplate

@lucasrod16 lucasrod16 mentioned this issue Apr 3, 2024
Merged
5 tasks
Noxsios added a commit that referenced this issue Apr 22, 2024
@Racer159 @lucasrod16
@AustinAbro321 @Noxsios
refactor: move variables into separate package (#2414)
cd9adb7 
## Description

Part of the actions refactor (split to reduce review time).

This PR splits variables into it's own library that does not depend on
Zarf specific code, fixes a bug with the new Helm Chart variables
injection and overhauls the variables docs to be more readable and
understandable and to include information on internal variables and the
Helm Chart variables.

## Related Issue

Relates to #2253
Fixes #2395
Fixes #1374

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <[email protected]>
Co-authored-by: Austin Abro <[email protected]>
Co-authored-by: razzle <[email protected]>
@github-project-automation github-project-automation bot moved this from New to Closed in Zarf Project Board Apr 22, 2024
@UncleGedd UncleGedd mentioned this issue Apr 22, 2024
Closed
@salaxander salaxander removed this from Zarf (old) Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
possible-bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move variables into separate package zarf-dev/zarf
1 participant
@UncleGedd