-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage class check can prevent deployments where no storage class is needed for the registry #2273
Comments
Was going to try a workaround. Seemed liked a bigger effort to get it back to 0.32.1 behavior. This stemmed from wanting to update to uds-cli v0.7.0 which uses zarf v0.32.2. I'm told that I should be able to use our custom zarf init v0.32.1 and should still work with the latest uds-cli even though it uses zarf v0.32.2. Its not always clear what versions of uds-cli are compatible with what versions of zarf. My assumption was they should always match? Will there always be NSYNC 🕺 versions of zarf and uds-cli? Could there be gaps? |
## Description #2180 introduced a bug and this PR removes the cause of the bug. Actions conditionals are being added to Zarf in #2276 to allow these sort of checks to account for various use cases in a more clean way. Also reopened #1824 ## Related Issue Relates to #2273 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Environment
Device and OS: System76 darp8
App version: v0.32.2
Kubernetes distro being used: any (as long as they have no storage class)
Other: n/a
Steps to reproduce
Expected result
Zarf successfully deploys
Actual Result
Zarf will fail with stating that it cannot find a storage class
Severity/Priority
Medium
Additional Context
There are work arounds with custom init packages but this use case should be handled since it is a regression from what the default Zarf init package used to be able to do.
The text was updated successfully, but these errors were encountered: