commonlib: Add ANTLR #6168
Open
commonlib: Add ANTLR #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
force-pushed
the
antlr-commonlib
branch
from
0f24460 to
3b2ad77
Compare
|
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
kingthorin
force-pushed
the
antlr-commonlib
branch
from
3b2ad77 to
77ed1aa
Compare
kingthorin
commented
Feb 7, 2025
Comment on lines
+66
to
+68
| tasks.named("generateGrammarSource") { | ||
| mustRunAfter(tasks.named("generateEffectiveLombokConfig")) | ||
| } |
There was a problem hiding this comment.
I have no idea if this is the best way to do this, it was the first way I found that worked.
Signed-off-by: kingthorin <[email protected]>
kingthorin
force-pushed
the
antlr-commonlib
branch
from
77ed1aa to
be594d7
Compare
thc202
reviewed
Feb 19, 2025
| import org.zaproxy.addon.commonlib.parserapi.impl.JavaScriptLexer; | ||
| import org.zaproxy.addon.commonlib.parserapi.impl.JavaScriptParser; | ||
|
|
||
| public class ParserApi { |
There was a problem hiding this comment.
This needs a proper API to extract/parse the JavaScript content. While this code might still be useful for more than one scan rule it needs to be cleaned up first.
There was a problem hiding this comment.
I guess we could remove the changelog entry and not bother announcing it until the other part is done? Or we can wait and expand it?I'm happy to push it further, just needed feedback. Do we need to start a doc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Split from: #3838 as we have other potential uses.
Related Issues
Checklist
./gradlew spotlessApplyfor code formatting