Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TEST_TIMING alert tag #6015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add TEST_TIMING alert tag #6015

wants to merge 1 commit into from

Conversation

kingthorin
Copy link
Member

Overview

Update: CHANGELOGs, scan rules, unittests.

Related Issues

N/A

Checklist

  • [na] Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@thc202 thc202 changed the title various: Add TEST_TIMING alert tag Add TEST_TIMING alert tag Dec 17, 2024
thc202
thc202 reviewed Dec 17, 2024
View reviewed changes
.../ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/CommandInjectionScanRule.java
@@ -98,7 +98,8 @@ public class CommandInjectionScanRule extends AbstractAppParamPlugin
CommonAlertTag.toMap(
CommonAlertTag.OWASP_2021_A03_INJECTION,
CommonAlertTag.OWASP_2017_A01_INJECTION,
CommonAlertTag.WSTG_V42_INPV_12_COMMAND_INJ));
CommonAlertTag.WSTG_V42_INPV_12_COMMAND_INJ,
CommonAlertTag.TEST_TIMING));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be included in all alerts raised by the rule which IMHO is misleading.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it looked like we had decided one example alert was sufficient

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can look at adding it differently.

It kinda needs to be on the rule for docs/site stuff (maybe I can remove it when it isn't a timing alert). Also kinda why I'd asked about rule vs alert tags way back.

I think the same applies for the shell shock rule.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be done similar to this: https://github.com/zaproxy/zap-extensions/pull/3798/files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to tweak a few others but how's that look for CMDi now?

@psiinon

This comment was marked as resolved.

Sign in to view
@kingthorin kingthorin force-pushed the timing-tag branch 2 times, most recently from e0f4158 to 58f25e1 Compare December 17, 2024 18:34
@kingthorin
Copy link
Member Author

Updated to be correct per rule, and correct per alert.

@kingthorin
Copy link
Member Author

Bump

1 similar comment
@kingthorin
Copy link
Member Author

Bump

@kingthorin
various: Add TEST_TIMING alert tag
81a36b4 
Update: CHANGELOGs, scan rules, unittests.

Signed-off-by: kingthorin <[email protected]>
# Conflicts:
#	addOns/ascanrules/CHANGELOG.md
#	addOns/ascanrulesBeta/CHANGELOG.md
@kingthorin
Copy link
Member Author

Deconflicted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thc202 thc202 thc202 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingthorin @psiinon @thc202