Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Testing components #41

Merged
merged 4 commits into from
Aug 14, 2019

Conversation

sawood14012
Copy link
Contributor

added default test cases for Box and Button components.
run npm test or yarn test to check
and use the same version of react dom , react and react test renderer

"react": "16.8.3", "react-dom": "16.8.3", "react-test-renderer": "16.8.3"

this test will produce files in snapshots folder like box.test.js.snap with the compiled result.

@welcome
Copy link

welcome bot commented Aug 14, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@sawood14012
Copy link
Contributor Author

I will update all the tests soon.. 😎

@piyush97
Copy link
Member

#41 Resolved Partially

@piyush97
Copy link
Member

@all-contributors add @sawood14012 as tester

@allcontributors
Copy link
Contributor

@piyush97

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@piyush97
Copy link
Member

@all-contributors add @sawood14012 as userTesting

@allcontributors
Copy link
Contributor

@piyush97

I've put up a pull request to add @sawood14012! 🎉

@piyush97 piyush97 self-requested a review August 14, 2019 05:43
@piyush97 piyush97 added the Testing Testing Components label Aug 14, 2019
@piyush97 piyush97 added this to the August Release milestone Aug 14, 2019
@piyush97 piyush97 requested review from is124, vinaybiradar1717 and a team August 14, 2019 05:44
Copy link
Member

@piyush97 piyush97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bhai please remove the appropriate comment lines. :)

Copy link
Member

@piyush97 piyush97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sawood14012 Please remove the comments

@@ -0,0 +1,27 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments like these

@piyush97 piyush97 merged commit a4bb10f into zapify-ui:testingComponents Aug 14, 2019
@welcome
Copy link

welcome bot commented Aug 14, 2019

Congrats on merging your first pull request! We here at Zapify are proud of you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Testing Testing Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants