Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/integrate-with-codeclimate #41

Merged
merged 7 commits into from
Nov 6, 2021

Conversation

KennethanCeyer
Copy link
Member

@KennethanCeyer KennethanCeyer commented Jul 25, 2021

🚀 Features

  • Add codeclimate integration (coverage, code quality)
  • Add workflow for testing, coveraging
  • Update README.md

Coverage integration

You can check by entering into below link

https://codeclimate.com/repos/60fd83052952e501a1000f8e/settings/test_reporter

image

The integration seems working

@KennethanCeyer KennethanCeyer marked this pull request as ready for review July 25, 2021 16:47
@KennethanCeyer KennethanCeyer changed the title WIP: feature/integrate-with-codeclimate feature/integrate-with-codeclimate Jul 25, 2021
@KennethanCeyer KennethanCeyer enabled auto-merge (squash) July 25, 2021 16:49
@zi-gae
Copy link
Member

zi-gae commented Jul 25, 2021

https://codeclimate.com/repos/60fd83052952e501a1000f8e/settings/test_reporter page authority impossible to check

@KennethanCeyer
Copy link
Member Author

@DevGW

Oh.. I'm not familiar with the codeclimate permission...
Could you confirm one thing for me? 🙏

Codeclimate Open source zap repo is now connected.
All current maintainers have zap repo privileges set to Admin.

In other words,
after connecting to codeclimate
you can see the zap repo if you sync in the Open source section. Can you give it a try?

@zi-gae
Copy link
Member

zi-gae commented Jul 26, 2021

@DevGW

Oh.. I'm not familiar with the codeclimate permission...
Could you confirm one thing for me? 🙏

Codeclimate Open source zap repo is now connected.
All current maintainers have zap repo privileges set to Admin.

In other words,
after connecting to codeclimate
you can see the zap repo if you sync in the Open source section. Can you give it a try?

I will try, thanks :)

@KennethanCeyer
Copy link
Member Author

KennethanCeyer commented Nov 6, 2021

@zi-gae

During initial setup (at least while blogging)
I'm going to turn off the Review Required option for the protected branch. (only for develop branch, master is still under the protected branch)
However, you can leave a review at any time! (And I'll reflect the review as soon as it is left)

This aims to get the cycle up to the initial setup of blog development relatively fast.

@KennethanCeyer KennethanCeyer merged commit ec540c3 into develop Nov 6, 2021
@KennethanCeyer KennethanCeyer deleted the feature/integrate-with-codeclimate branch November 6, 2021 09:26
@zi-gae
Copy link
Member

zi-gae commented Nov 6, 2021

@zi-gae

During initial setup (at least while blogging) I'm going to turn off the Review Required option for the protected branch. (only for develop branch, master is still under the protected branch) However, you can leave a review at any time! (And I'll reflect the review as soon as it is left)

This aims to get the cycle up to the initial setup of blog development relatively fast.

I agree with this discussion 🙆🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants