Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where changelog_ignore_labels was not respected #12

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix bug where changelog_ignore_labels was not respected #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/rooster/_changelog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,14 @@ def generate_changelog(pull_requests: list[PullRequest], config: Config) -> str:
for label in pull_request.labels:
if label in config.changelog_ignore_labels:
break
# Iterate in-order of changelog sections to support user-configured precedence
for label in config.changelog_sections:
if label in pull_request.labels:
sections[label].append(pull_request)
break
else:
sections["__unknown__"].append(pull_request)
# Iterate in-order of changelog sections to support user-configured precedence
for label in config.changelog_sections:
if label in pull_request.labels:
sections[label].append(pull_request)
break
else:
sections["__unknown__"].append(pull_request)

for section, pull_requests in sections.items():
# Omit empty sections
Expand Down