update to tfhe-rs 1.0.0 #164
Conversation
rudy-6-4
force-pushed
the
rudy/chore/bump-tfhers
branch
from
c208dbe to
9c2fdf9
Compare
rudy-6-4
force-pushed
the
rudy/chore/bump-tfhers
branch
from
9c2fdf9 to
c0e688d
Compare
| @@ -0,0 +1,14 @@ | |||
| # Dependency update | |||
There was a problem hiding this comment.
Thx for doing it! To be reviewed by @immortal-tofu please, later, even if the PR is merged
There was a problem hiding this comment.
Yes there is also tkms to update to be fully tfhers 1.0.0.
And I can prerelease without merging.
There was a problem hiding this comment.
And I can prerelease without merging.
Awesome, but at the same time, it means our release / prerelease are not done on "real commits"?
There was a problem hiding this comment.
There are real commit but not on main branch (they will be when Clement is back). There's even a prerelease tag to be sure we track them. Is this an issue for you ? A release is often done on release branch BTW not on main, so if you have rc/fix etc it happens outside of main.
There was a problem hiding this comment.
Eg, what happens if we squash commits? To me, we should do release on things which are merged, not on commits which are still in a PR
No description provided.