Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo in typedef of FhevmInstance #148

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

jatZama
Copy link
Member

@jatZama jatZama commented Dec 8, 2024

No description provided.

@jatZama jatZama requested a review from immortal-tofu December 8, 2024 23:27
Copy link

cla-bot bot commented Dec 8, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: jatZama.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@immortal-tofu
Copy link
Collaborator

delegatedAccount could be misleading with the delegate account function

@jatZama
Copy link
Member Author

jatZama commented Dec 8, 2024

delegatedAccount could be misleading with the delegate account function

Sorry I don't understand your point. I noticed the implementation of createEncryptedInput has as an optional argument the delegatedAccount argument already so I wanted to use same name in the type definition to avoid confusion.

@immortal-tofu immortal-tofu merged commit 5aac20d into main Dec 8, 2024
3 checks passed
@immortal-tofu
Copy link
Collaborator

delegatedAccount could be misleading with the delegate account function

Sorry I don't understand your point. I noticed the implementation of createEncryptedInput has as an optional argument the delegatedAccount argument already so I wanted to use same name in the type definition to avoid confusion.

Sorry I thought it was for encrypt. All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants