Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract in package + bugfix contractowner blind auction #73

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Abstract in package + bugfix contractowner blind auction #73

merged 2 commits into from
Jul 7, 2023

Conversation

immortal-tofu
Copy link
Contributor

  • Merge the fix on blinc auction for stop()
  • Move abstract at root and add it in the npm package.
  • Move @OpenZeppelin dependency as non-dev dependency

tremblaythibaultl
tremblaythibaultl approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@tremblaythibaultl tremblaythibaultl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@immortal-tofu immortal-tofu merged commit 2828fc7 into main Jul 7, 2023
@immortal-tofu immortal-tofu deleted the feature/abstract-in-package branch July 21, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremblaythibaultl tremblaythibaultl tremblaythibaultl approved these changes

@dartdart26 dartdart26 Awaiting requested review from dartdart26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@immortal-tofu @tremblaythibaultl