Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker image build #1313

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Fix docker image build #1313

merged 6 commits into from
Aug 26, 2021

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Aug 24, 2021

Fix Docker image build

@vadeg vadeg self-assigned this Aug 24, 2021
@vadeg vadeg requested review from tkrop and zeitlinger as code owners August 24, 2021 19:31
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #1313 (4d4f12d) into master (679f5dd) will increase coverage by 2.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1313      +/-   ##
============================================
+ Coverage     72.91%   75.05%   +2.13%     
  Complexity      932      932              
============================================
  Files           135      167      +32     
  Lines          2304     2682     +378     
  Branches        437      492      +55     
============================================
+ Hits           1680     2013     +333     
- Misses          378      410      +32     
- Partials        246      259      +13     
Impacted Files Coverage Δ
web-ui/src/client/app/containers/url.jsx 94.44% <0.00%> (ø)
web-ui/src/client/app/services/fetch.js 100.00% <0.00%> (ø)
web-ui/src/client/app/index.jsx 100.00% <0.00%> (ø)
web-ui/src/client/app/components/editor.jsx 88.88% <0.00%> (ø)
web-ui/src/server/handlers/window-env.js 100.00% <0.00%> (ø)
web-ui/src/client/app/services/oauth-firewall.js 100.00% <0.00%> (ø)
web-ui/src/client/app/containers/login.jsx 100.00% <0.00%> (ø)
web-ui/src/server/handlers/index.js 100.00% <0.00%> (ø)
web-ui/src/client/app/components/rules.jsx 100.00% <0.00%> (ø)
web-ui/src/client/app/components/violations.jsx 88.88% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679f5dd...4d4f12d. Read the comment docs.

@vadeg vadeg added status: blocked The issue is blocked by other issue in external dependency status: pending Pending actions status: work in progress and removed status: work in progress status: blocked The issue is blocked by other issue in external dependency labels Aug 26, 2021
@zalando-robot
Copy link

Docker image "pierone.stups.zalan.do/pitchfork/zally-web-ui-dummy:master-679f5dd4-901" is not based on an approved base image. Any production deployment relying on this image will be blocked.

To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace library and use a recommended version as listed in the documentation.

@vadeg vadeg changed the title Build image Fix docker image build Aug 26, 2021
@vadeg
Copy link
Contributor Author

vadeg commented Aug 26, 2021

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented Aug 26, 2021

👍

@tkrop tkrop merged commit 0a21a91 into master Aug 26, 2021
@tkrop tkrop deleted the test-image-build branch August 26, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants