Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

opentracing: add timeout tag to fragment spans #270

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

vigneshshanmugam
Copy link
Collaborator

  • Helps in tracing when there are timeout issues with the remote fragment endpoint.

@vigneshshanmugam
Copy link
Collaborator Author

👍

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@22608d3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #270   +/-   ##
=========================================
  Coverage          ?   99.55%           
=========================================
  Files             ?       17           
  Lines             ?      670           
  Branches          ?      127           
=========================================
  Hits              ?      667           
  Misses            ?        3           
  Partials          ?        0
Impacted Files Coverage Δ
lib/fragment.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22608d3...bc77fbc. Read the comment docs.

@mo-gr
Copy link
Contributor

mo-gr commented Nov 14, 2018

👍

@vigneshshanmugam vigneshshanmugam merged commit ab689b3 into master Nov 14, 2018
@vigneshshanmugam vigneshshanmugam deleted the trace-timeout branch November 14, 2018 15:18
@lmineiro
Copy link
Contributor

This looked more appropriate as a log field if it will contain just the info about the current fragment timeout. It's expected to change and not very deterministic anyway. As information, it would be a good log field, imho

@vigneshshanmugam
Copy link
Collaborator Author

I agree with you, But I had put it as tag for two reasons

  1. Need to keep the consistency of existing attributes and do not treat this field in any different way.
  2. Since logs fields aren't searchable and for debugging purposes once I can get the timeout information, I can still search for timeout even though it isn't deterministic.

We already log on z-tailor with the timeout error with specified read and connection timeouts which maps with the error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants