This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 141
add custom api for adding ttfmp from fragments #214
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -167,21 +167,29 @@ | |
} | ||
/* | ||
* Custom Performance entries that can be added from fragments | ||
* Its need because Browsers currently does not allow expose any API to add | ||
* It's needed because browsers currently do not expose an API to add | ||
* custom timing information to performance entries | ||
*/ | ||
function addPerfEntry(name, duration) { | ||
// Should not add to entries when Navigation timing is not supported. | ||
if (!'timing' in perf) { | ||
return; | ||
} | ||
// duplicate entries are not handled to keep the API | ||
// similar to PerformanceEntry Object | ||
// https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry | ||
entries.push({ | ||
name: name, | ||
duration: Number(duration), | ||
entryType: 'tailor', | ||
startTime: perf.now() || Date.now() - perf.timing.navigationStart | ||
}); | ||
} | ||
// Unique API that allows fragments to specify the | ||
// time to first meaningul paint of the page | ||
function addTTFMPEntry(duration) { | ||
addPerfEntry('ttfmp', duration); | ||
} | ||
// Retrive the added entries from fragments for monitoring | ||
function getEntries() { | ||
return entries; | ||
|
@@ -203,6 +211,7 @@ | |
onAfterInit: assignHook('onAfterInit'), | ||
onDone: assignHook('onDone'), | ||
addPerfEntry: addPerfEntry, | ||
addTTFMPEntry: addTTFMPEntry, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bind is slow in older versions of v8 (older browsers might suffer from this). Thats why i went for explicit function. But, its just one time call so shouldn't matter much. |
||
getEntries: getEntries | ||
}; | ||
})(window.document, window.performance); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just keeping it as
ttfmp
to avoid the name collision in future oncefirst-meaningful-paint
is added to Paint Timing