This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
remove uncessary check for parse result #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vigneshshanmugam
commented
Sep 11, 2017
vigneshshanmugam
commented
- the serialised parsed template is always an array.
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 96.95% 97.12% +0.16%
==========================================
Files 14 14
Lines 559 557 -2
Branches 94 93 -1
==========================================
- Hits 542 541 -1
+ Misses 17 16 -1
Continue to review full report at Codecov.
|
|
👍 |
1 similar comment
|
👍 |
| } else { | ||
| resultStream.end(parsedTemplate); | ||
| } | ||
| parsedTemplate.forEach((item) => { |
There was a problem hiding this comment.
@vigneshshanmugam Would it make sense to add a test or a task to add test for this module?
There was a problem hiding this comment.
Its already there in tests/parse-template.. since we never reached this part, codecov was decreased. I found this only through codecov report.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.