Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

propagate the error properly to tailor errors [fixes #178] #179

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

vigneshshanmugam
Copy link
Collaborator

@vigneshshanmugam vigneshshanmugam commented Sep 7, 2017

  • Error was not rethrown before back to the fetchTemplate function
  • Added a test case for the missing case.

@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@99ba67e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #179   +/-   ##
=========================================
  Coverage          ?   96.79%           
=========================================
  Files             ?       14           
  Lines             ?      561           
  Branches          ?       94           
=========================================
  Hits              ?      543           
  Misses            ?       18           
  Partials          ?        0
Impacted Files Coverage Δ
lib/fetch-template.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ba67e...cd32d06. Read the comment docs.

@DeTeam
Copy link
Contributor

DeTeam commented Sep 7, 2017

👍

1 similar comment
@vigneshshanmugam
Copy link
Collaborator Author

👍

@vigneshshanmugam vigneshshanmugam merged commit bf87709 into master Sep 7, 2017
@vigneshshanmugam vigneshshanmugam deleted the error-propagation branch September 7, 2017 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants