Update Buffer to use Node v8 syntax

[addityasingh]

• closes fix deprecation warnings in Node 8 #149
• Update Buffer to use Node v8 syntax

[vigneshshanmugam]

Can you run the benchmark with Buffer.from and Buffer.allocUnsafe?

Also zero fill the buffer with Buffer.allowUnsafe(0)

[addityasingh]

The benchmark tests are failing for me with a TCP socket timeout error

[vigneshshanmugam]

Tested the benchmarks with

With buffer.from

Tailor Overhead Metrics {
  "type": "histogram",
  "min": 0.16044899999997142,
  "max": 51.542193999999995,
  "sum": 4812.023433999978,
  "variance": 1.5396951250332829,
  "mean": 0.4806736024373219,
  "std_dev": 1.240844520894251,
  "count": 10011,
  "median": 0.3414210000000253,
  "p75": 0.44491949999996905,
  "p95": 0.7591170000000087,
  "p99": 1.922573709999998,
  "p999": 50.62678896100011
}

With allocUnsafe and fill

Tailor Overhead Metrics {
  "type": "histogram",
  "min": 0.16987999999997783,
  "max": 66.15484600000002,
  "sum": 5323.567117000002,
  "variance": 2.0253315784060777,
  "mean": 0.5344410317237258,
  "std_dev": 1.4231414470832047,
  "count": 9961,
  "median": 0.38589300000001003,
  "p75": 0.5101299999999895,
  "p95": 0.9364355499999815,
  "p99": 3.4285971000000406,
  "p999": 19.733977497999973
}

[addityasingh]

looks like Buffer.alloc() numbers look better than allocUnsafe() and fill() upto p99. 👍

[addityasingh]

@vigneshshanmugam Can you check and confirm if the examples with parse-template are working for you after this change?

node examples/fragment-performance
node examples/multiple-fragments-with-custom-amd

The above 2 seems to be broken with error:

TypeError: this.html.charCodeAt is not a function
at Preprocessor.advance (/Users/adisingh/Documents/dev/projects/node/tailor/node_modules/parse5/lib/tokenizer/preprocessor.js:124:24)
at Tokenizer._consume (/Users/adisingh/Documents/dev/projects/node/tailor/node_modules/parse5/lib/tokenizer/index.js:278:30)
at Tokenizer.getNextToken (/Users/adisingh/Documents/dev/projects/node/tailor/node_modules/parse5/lib/tokenizer/index.js:236:23)
at Parser._runParsingLoop (/Users/adisingh/Documents/dev/projects/node/tailor/node_modules/parse5/lib/parser/index.js:393:36)
at Parser.parse (/Users/adisingh/Documents/dev/projects/node/tailor/node_modules/parse5/lib/parser/index.js:322:10)
at Object.parse (/Users/adisingh/Documents/dev/projects/node/tailor/node_modules/parse5/lib/index.js:11:19)
at Transform.applyTransforms (/Users/adisingh/Documents/dev/projects/node/tailor/lib/transform.js:27:34)
at Promise.resolve.then.transform (/Users/adisingh/Documents/dev/projects/node/tailor/lib/parse-template.js:14:43)

[vigneshshanmugam]

Weird. It works properly for me and the tests are passing on all versions.

Can you give the node version?

[addityasingh]

node v7.8.0