Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

To use 'Promisify' to simplify the code #172

Closed
luizdesign opened this issue Aug 23, 2017 · 8 comments
Closed

To use 'Promisify' to simplify the code #172

luizdesign opened this issue Aug 23, 2017 · 8 comments

Comments

@luizdesign
Copy link
Contributor

luizdesign commented Aug 23, 2017 •
edited
Loading

Continue the discuss about use promisify started in #171 (#171 (comment))
@luizdesign luizdesign mentioned this issue Aug 23, 2017
Merged
@addityasingh
Copy link
Contributor

@vigneshshanmugam Based on our discussion earlier on the PR for this issue here, I remember that the util.promisify library had some performance issue because of prototype chaining. Do you think it still makes sense to https://github.com/ljharb/util.promisify library?

@vigneshshanmugam
Copy link
Collaborator

@addityasingh Lets reopen the PR and add the remaining changes if you are interested in taking it forward. Most projects are using it these days.

@addityasingh
Copy link
Contributor

@luizdesign If you want to work on it, please go ahead. Else, I can take it up

@addityasingh
Copy link
Contributor

Duplicate of #153

@luizdesign
Copy link
Contributor Author

@addityasingh I didn't start work on it yet, I'm working to finish the changes to #171

@addityasingh
Copy link
Contributor

Cool. Let me make the changes quickly then

@vigneshshanmugam vigneshshanmugam mentioned this issue Aug 25, 2017
Closed
@vigneshshanmugam
Copy link
Collaborator

You guys wanna take it up?

@addityasingh addityasingh mentioned this issue Sep 2, 2017
Merged
@addityasingh
Copy link
Contributor

@vigneshshanmugam Please have a look now

vigneshshanmugam pushed a commit that referenced this issue Sep 4, 2017
@addityasingh @vigneshshanmugam
Use the node v8 promisify API to remove unnecessary code (#174)
4d8d830 
* #172 Use the node v8 promisify API to remove unnecessary code

* #172 Remove unnecessary space

* #172 #153 Add yarn lock file
@vigneshshanmugam vigneshshanmugam mentioned this issue Sep 4, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luizdesign @vigneshshanmugam @addityasingh