filters/auth: add -oauth2-token-cookie-remove-subdomains flag #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+95
to
+98
| // TokenCookieRemoveSubdomains sets the number of subdomains to remove from | ||
| // the callback request hostname to obtain token cookie domain. | ||
| // Init converts default nil to 1. | ||
| TokenCookieRemoveSubdomains *int |
There was a problem hiding this comment.
To stay backwards-compatible I had to use pointer here to tell zero and default value (one) apart.
The proper config initialization requires Init() call.
If we can sacrifice a bit of compatibility for library users then we could use just int and rely on the default skipper flag value of 1.
There was a problem hiding this comment.
There are not many options here https://stackoverflow.com/questions/68800319/how-to-differentiate-int-null-and-defaulted-to-zero-from-int-actually-equal-to-z
We could also create a wrapper type but that feels too much.
There was a problem hiding this comment.
If you need this 3 state: 0 value, 0, N, then ptr is the way to go
See related #1909 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
filters/auth/grant-cookie-subdomains
branch
from
0b35759 to
c2d64ab
Compare
szuecs
reviewed
Jan 19, 2023
| @@ -214,14 +217,22 @@ func checkStatus(t *testing.T, rsp *http.Response, expectedStatus int) { | |||
| } | |||
| } | |||
|
|
|||
| func checkRedirect(t *testing.T, rsp *http.Response, expectedURL string) { | |||
| func checkRedirect(t *testing.T, rsp *http.Response, expectedLocationWithoutQuery string) { | |||
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 1, 2024
Followup on #2203 Followup on #2244 Followup on #2457 Updates #2898 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 5, 2024
Followup on #2203 Followup on #2244 Followup on #2457 Updates #2898 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related #1909
Signed-off-by: Alexander Yastrebov [email protected]