Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to prevent PVC removal on cluster deletion #2579

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Mar 14, 2024

closes #2567
addresses #1074

A long wished for feature to stop operator from deleting PVCs. To avoid confusion with the new PVC retention policy feature added in #2343 for which I added the missing documentation.

@FxKu FxKu added this to the 1.11.0 milestone Mar 14, 2024
Copy link
Contributor

@dmotte dmotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @FxKu for this PR :)

I just noticed a little typo and left a comment

@FxKu
Copy link
Member Author

FxKu commented Mar 14, 2024

👍

1 similar comment
@idanovinda
Copy link
Member

👍

@FxKu FxKu merged commit 08089ed into master Mar 14, 2024
9 checks passed
@FxKu FxKu deleted the pvc-deletion-toggle branch March 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants