Feat: add flags for podPriorityClassName to support external priorityclasses #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capuche2412
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda and
hughcapet
as code owners
capuche2412
changed the title
capuche2412
changed the title
FxKu
reviewed
Jan 25, 2024
FxKu
reviewed
Jan 25, 2024
charts/postgres-operator/templates/postgres-pod-priority-class.yaml
Outdated
Show resolved
Hide resolved
capuche2412
force-pushed
the
feat/allow-external-priorityclassname-for-postgres-pods
branch
from
97a1415 to
4f01234
Compare
|
I notice another scenario that is not being taken into account. If someone explicitly does not want to set a priorityClassName, it is not possible to do so here. A priorityClass will still be created. This could be perceived as unnecessary boilerplate, especially in a cluster that does not utilize custom priorityClasses at all. |
|
I don get your last comment. The default should be false like before. The priority class should not get created if somebody does not want to use it. You have to enable it manually in the values.yaml file. (It's funny after all those years I still see no use in helm charts haha) |
capuche2412
commented
Jan 29, 2024
capuche2412
force-pushed
the
feat/allow-external-priorityclassname-for-postgres-pods
branch
from
4f01234 to
30f95d9
Compare
Signed-off-by: Arthur Le Roux <[email protected]>
capuche2412
force-pushed
the
feat/allow-external-priorityclassname-for-postgres-pods
branch
from
30f95d9 to
c1f5946
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
To solve this issue #2441, I present a possible solution by adding flags to create the PriorityClass (or not) and to set the priority. In case of a use of an external priorityclass, only the name should be set.