-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logical backup secret #2051
Logical backup secret #2051
Conversation
The other implementation is "probably" better. Mine is definitely simpler. I'm not sure which warrants inclusion in the next release, but can say I've deployed mine to our non-prod environments. |
Whats holding this back? or have 2 who can approve just not reviewed it yet? |
Any update, we are waiting on this one for long |
@yajo @nihaldivyam I see you both approved this.. and yet the ZAPPR status says its "pending 2 approvals - 0/2 given" ? |
@yajo @nihaldivyam thank you for approving, any update on when this can be merged. ? |
I have no authority in this project, no idea. I see this one has conflicts though, so even maintainers won't be able to merge. |
@yajo should be solved now |
@stgrace thanks for providing this feature. I will have a look. You have to fix your unit test, too? Only +1 from project maintainers count for zappr btw. |
Looking forward to this being done 😄 |
@stgrace Eagerly waiting for this to get merged !! |
@FxKu thank you for adding this to a milestone - but when will it be merged? its a "small thing" - and its really annoying we have to implement our until this works properly :( |
@KlavsKlavsen we need this too. |
@idanovinda @FxKu Eagerly waiting for this to get merged too ! |
Hi everyone,
|
@FxKu can you please look in the above issues |
it would be nice if this got merged, no one wants their s3 credentials in plain text :) |
Eagerly waiting for this to get merged! |
👍 |
1 similar comment
👍 |
Thanks @stgrace for your contribution and sorry it took us so long too merge it. |
See #2050