This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Start docker container if it already exists. Fix #199 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for an issue with startup sequence when we have external volumes to mount. In case of EC2 instance restart the Docker daemon will start prior to taupage-init and will immediately try to start the container it was running prior to the restart. This will fail because the volumes are not there yet, they are mounted as part of taupage-init script, in 10-prepare-disks.py. Starting the container explicitly "fixes" the problem because at that point all required initialization steps are completed.
|
Looks good to me 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for an issue with startup sequence when we
have external volumes to mount. In case of EC2 instance restart
the Docker daemon will start prior to taupage-init and will
immediately try to start the container it was running prior to
the restart. This will fail because the volumes are not there yet,
they are mounted as part of taupage-init script, in 10-prepare-disks.py.
Starting the container explicitly "fixes" the problem because at that
point all required initialization steps are completed.