Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Measure the code coverage and upload reports #72

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented May 24, 2019

Issue : closes #99, previously #13

(Playing with CodeCov and branches, need the real PR for this.)


Tools:

Few tools are enabled for the same coverage measurements. More can be added over time — to compare and to use the benefits of all of them.


Historic measurements:

The code coverage measurements for CodeCov were replayed for the whole git log — i.e. every commit — to render the graph nicely.

Coveralls does not date the coverage uploads to the commit timestamps (or it seems so), so it makes no sense to replay.

The ad-hoc script for replaying the history is here: https://gist.github.com/nolar/35c73e7a0caa37a30f0a37bdebb5d574

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label May 24, 2019
@nolar nolar requested a review from samurang87 as a code owner May 24, 2019 17:27
@zincr
Copy link

zincr bot commented May 24, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Dependency Licensing
✅ Large Commits
✅ Approvals
✅ Specification

Details on how to resolve are provided below


Dependency Licensing

All dependencies specified in package manager files must be reviewed, banned dependency licenses will block the merge, all new dependencies introduced in this pull request will give a warning, but not block the merge

Please ensure that only dependencies with licenses compatible with the license of this project is included in the pull request.

  • ℹ️ Could not process requirements.txt for new dependencies
     

@zincr
Copy link

zincr bot commented May 24, 2019

🤖 zincr found 1 problem , 1 warning

❌ Approvals
ℹ️ Dependency Licensing
✅ Large Commits
✅ Specification

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

Dependency Licensing

All dependencies specified in package manager files must be reviewed, banned dependency licenses will block the merge, all new dependencies introduced in this pull request will give a warning, but not block the merge

Please ensure that only dependencies with licenses compatible with the license of this project is included in the pull request.

  • ℹ️ Could not process requirements.txt for new dependencies
     

@nolar nolar added this to the 1.0 milestone May 24, 2019
@zalando-incubator zalando-incubator deleted a comment from codecov-io May 24, 2019
@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@130d3a4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #72   +/-   ##
=========================================
  Coverage          ?   63.14%           
=========================================
  Files             ?       21           
  Lines             ?     1080           
  Branches          ?      152           
=========================================
  Hits              ?      682           
  Misses            ?      385           
  Partials          ?       13
Flag Coverage Δ
#e2e 63.14% <ø> (?)
#unit 63.14% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130d3a4...cd63a6e. Read the comment docs.

@nolar nolar mentioned this pull request May 25, 2019
19 tasks
@nolar nolar force-pushed the coverage branch 2 times, most recently from cd63a6e to 5310428 Compare June 6, 2019 15:45
samurang87
samurang87 previously approved these changes Jun 21, 2019
@codecov-io
Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #72 into master will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   83.81%   84.04%   +0.23%     
==========================================
  Files          29       29              
  Lines        1433     1454      +21     
  Branches      211      212       +1     
==========================================
+ Hits         1201     1222      +21     
  Misses        194      194              
  Partials       38       38
Impacted Files Coverage Δ
kopf/clients/fetching.py 100% <0%> (ø) ⬆️
kopf/reactor/registries.py 89.58% <0%> (+0.37%) ⬆️
kopf/engines/peering.py 28.34% <0%> (+0.56%) ⬆️
kopf/cli.py 87.09% <0%> (+1.13%) ⬆️
kopf/testing/runner.py 81.57% <0%> (+2.16%) ⬆️

@nolar nolar merged commit 394ef18 into zalando-incubator:master Jul 9, 2019
@nolar nolar deleted the coverage branch July 9, 2019 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measure test coverage
3 participants