This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Document the preservation of Kopf's persistence state in "v1" CRDs #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Convert CRDs from v1beta1 to v1 API version, and document the unknown field preservation for Kopf's status storage.
Description
Kubernetes 1.16 introduced new changes to custom and built-in resources with stricter schemas and no possibility for arbitrary field storage by default:
There are workarounds though — via
x-kubernetes-preserve-unknown-fields: true
.This PR documents these workarounds and upgrades the framework's CRDs to v1. Legacy CRDs for Kubernetes <= 1.15 are stored nearby (useful when starting in e.g. GKE with default K8s 1.14 and maximum 1.15).
The CRD definition is the only difference. The framework is supposed to work with both versions of CRDs. And the new annotations storage (#331) should solve the root problem "properly" via the code.
Issues/PRs
Type of changes
Checklist