This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Limit persistence annotations to 63 chars #346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Limit Kopf's annotations' names to 63 characters.
Description
An issue found the hard way (though we hit it before): when an annotation's name is 64 or more characters, it is not accepted by K8s API. This is documented.
For example if we have a prefix, a long function name, and maybe a field suffix:
kopf.zalando.org/some_resource_of_interest_created.status.childname
— and oops, it is 67 already, while 63 is allowed.This PR fixes the issue with lengthy handler ids by cutting their tail, and replacing it with some consistent one-way hash — this makes the annotation unique enough, and still recognisable/readable for the primary part of its name.
Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt