Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Better naming for timeouts + connection timeout #337

Merged
merged 3 commits into from
Mar 29, 2020

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Mar 27, 2020

What do these changes do?

Follow-ups for #336 with better naming of the timeout settings.

Description

#336 was merged but not released yet, so it is fine to quickly change the names without backward compatibility implemented.

In addition, a connection timeout is added for watching streams — to distinguish it from the total timeout on the client side (which is supposed to be infinite in a perfect world). The connection timeout is needed to handle the cases of broken networking in some cluster setups — for which kopf.config.WatchersConfig.session_timeout was originally introduced in #322 .

Issues/PRs

Issues: #23

Related: #322 #192 #109

Type of changes

  • New feature (non-breaking change which adds functionality)
  • Mostly documentation and examples (no code changes)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

@nolar nolar added the enhancement New feature or request label Mar 27, 2020
@zincr
Copy link

zincr bot commented Mar 27, 2020

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Mar 27, 2020

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar mentioned this pull request Mar 27, 2020
5 tasks
@nolar nolar merged commit 842a907 into zalando-incubator:master Mar 29, 2020
@nolar nolar deleted the settings-naming-followup branch March 29, 2020 23:28
@nolar nolar added this to the 0.27 milestone May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants