This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Better naming for timeouts + connection timeout #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Follow-ups for #336 with better naming of the timeout settings.
Description
#336 was merged but not released yet, so it is fine to quickly change the names without backward compatibility implemented.
In addition, a connection timeout is added for watching streams — to distinguish it from the total timeout on the client side (which is supposed to be infinite in a perfect world). The connection timeout is needed to handle the cases of broken networking in some cluster setups — for which
kopf.config.WatchersConfig.session_timeout
was originally introduced in #322 .Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt