Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Install conntrack to pass CI/CD with K8s 1.18 #335

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Mar 26, 2020

What do these changes do?

Fix the CI/CD tests with Kubernetes 1.18, which now requires conntrack.

Description

Since Kubernetes 1.18 release (since 25.03.2020), the CI/CD tests are broken:

error execution phase preflight: [preflight] Some fatal errors occurred:
	[ERROR FileExisting-conntrack]: conntrack not found in system path

This PR fixes it.

Issues/PRs

Issues: fixes #334

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Mostly CI/CD automation, contribution experience

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

@nolar nolar added the bug Something isn't working label Mar 26, 2020
@nolar nolar requested a review from haikoschol March 26, 2020 09:03
@zincr
Copy link

zincr bot commented Mar 26, 2020

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Mar 26, 2020

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Mar 26, 2020
@nolar nolar merged commit fedb1cd into zalando-incubator:master Mar 26, 2020
@nolar nolar deleted the fix-conntrack-in-cicd branch March 26, 2020 09:43
@nolar nolar added this to the 0.27 milestone May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail with "conntrack not found" for K8s 1.18
2 participants