Switch to py38 as the primary CI version, keep py37 tested

.travis.yml

@@ -26,13 +26,20 @@ env:
 #    - KUBERNETES_VERSION=v1.11.10  # Minikube fails on CRI preflight checks
 #    - KUBERNETES_VERSION=v1.10.13  # CRDs require spec.version, which fails on 1.14
 
+# Only one Python version is tested with all supported K8s versions: to check for API compatibility.
+# Other Python versions are tested with only one K8s version: if it works for one, it works for all.
+# One look-ahead Python dev version is tested for preview, but is optional.
 python:
-  - "3.7"
+  - "3.8"
 matrix:
   include:
-    - python: "3.8-dev"
+    - python: "3.7"
+      env: KUBERNETES_VERSION=latest CLIENT=yes
+    - python: "3.7"
+      env: KUBERNETES_VERSION=latest CLIENT=no
+    - python: "3.9-dev"
   allow_failures:
-    - python: "3.8-dev"
+    - python: "3.9-dev"
 
 before_script:
   - tools/minikube-for-travis.sh

kopf/reactor/running.py

@@ -180,9 +180,9 @@ async def spawn_tasks(
     memories = memories if memories is not None else containers.ResourceMemories()
     vault = vault if vault is not None else global_vault
     vault = vault if vault is not None else credentials.Vault()
-    event_queue: posting.K8sEventQueue = asyncio.Queue(loop=loop)
-    freeze_mode: primitives.Toggle = primitives.Toggle(loop=loop)
-    signal_flag: asyncio_Future = asyncio.Future(loop=loop)
+    event_queue: posting.K8sEventQueue = asyncio.Queue()
+    freeze_mode: primitives.Toggle = primitives.Toggle()
+    signal_flag: asyncio_Future = asyncio.Future()
     ready_flag = ready_flag if ready_flag is not None else asyncio.Event()
     tasks: MutableSequence[asyncio_Task] = []
 

kopf/structs/credentials.py

@@ -112,20 +112,18 @@ class Vault(AsyncIterable[Tuple[VaultKey, ConnectionInfo]]):
     def __init__(
             self,
             __src: Optional[Mapping[str, object]] = None,
-            *,
-            loop: Optional[asyncio.AbstractEventLoop] = None,
     ) -> None:
         super().__init__()
         self._current = {}
         self._invalid = collections.defaultdict(list)
-        self._lock = asyncio.Lock(loop=loop)
+        self._lock = asyncio.Lock()
 
         if __src is not None:
             self._update_converted(__src)
 
         # Mark a pre-populated vault to be usable instantly,
         # or trigger the initial authentication for an empty vault.
-        self._ready = primitives.Toggle(bool(self), loop=loop)
+        self._ready = primitives.Toggle(bool(self))
 
     def __repr__(self) -> str:
         return f'<{self.__class__.__name__}: {self._current!r}>'

kopf/structs/primitives.py

@@ -71,17 +71,11 @@ class Toggle:
     def __init__(
             self,
             __val: bool = False,
-            *,
-            loop: Optional[asyncio.AbstractEventLoop] = None,
     ) -> None:
         super().__init__()
-        self._condition = asyncio.Condition(loop=loop)
+        self._condition = asyncio.Condition()
         self._state: bool = bool(__val)
 
-    @property
-    def loop(self) -> asyncio.AbstractEventLoop:
-        return self._condition._loop
-
     def __bool__(self) -> bool:
         """
         In the boolean context, a toggle evaluates to its current on/off state.

tests/conftest.py

@@ -29,6 +29,12 @@ def pytest_configure(config):
     # Unexpected warnings should fail the tests. Use `-Wignore` to explicitly disable it.
     config.addinivalue_line('filterwarnings', 'error')
 
+    # Warnings from the testing tools out of our control should not fail the tests.
+    config.addinivalue_line('filterwarnings', 'ignore:"@coroutine":DeprecationWarning:asynctest.mock')
+    config.addinivalue_line('filterwarnings', 'ignore:The loop argument:DeprecationWarning:aiohttp')
+    config.addinivalue_line('filterwarnings', 'ignore:The loop argument:DeprecationWarning:aiojobs')
+    config.addinivalue_line('filterwarnings', 'ignore:The loop argument:DeprecationWarning:asyncio.queues')  # aiojobs
+
 
 def pytest_addoption(parser):
     parser.addoption("--only-e2e", action="store_true", help="Execute end-to-end tests only.")
@@ -314,7 +320,7 @@ def clean_kubernetes_client():
 
 
 @pytest.fixture()
-def fake_vault(event_loop, mocker, hostname):
+def fake_vault(mocker, hostname):
     """
     Provide a freshly created and populated authentication vault for every test.
 
@@ -328,7 +334,7 @@ def fake_vault(event_loop, mocker, hostname):
 
     key = VaultKey('fixture')
     info = ConnectionInfo(server=f'https://{hostname}')
-    vault = Vault({key: info}, loop=event_loop)
+    vault = Vault({key: info})
     token = auth.vault_var.set(vault)
     mocker.patch.object(vault._ready, 'wait_for_on')
     mocker.patch.object(vault._ready, 'wait_for_off')

tests/posting/conftest.py

@@ -15,8 +15,8 @@ def event_queue_loop(event_loop):
 
 
 @pytest.fixture()
-def event_queue(event_loop):
-    queue = asyncio.Queue(loop=event_loop)
+def event_queue():
+    queue = asyncio.Queue()
     token = event_queue_var.set(queue)
     try:
         yield queue

tests/primitives/test_toggles.py

@@ -1,24 +1,10 @@
 import asyncio
-import contextlib
 
 import pytest
 
 from kopf.structs.primitives import Toggle
 
 
-async def test_creation_with_default_loop():
-    loop = asyncio.get_running_loop()
-    toggle = Toggle()
-    assert toggle.loop is loop
-
-
-async def test_creation_with_explicit_loop():
-    loop = asyncio.new_event_loop()
-    with contextlib.closing(loop):
-        toggle = Toggle(loop=loop)
-        assert toggle.loop is loop
-
-
 async def test_created_as_off():
     toggle = Toggle()