Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Avoid meaningless logging and patching #236

Merged
merged 3 commits into from
Nov 15, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Nov 15, 2019

Less patching, less logging when not needed.

Issue : #1234 (only if appropriate)

Description

Skip logging the empty diffs. They are useless. Especially on the resuming events, when the object is not changed actually. — As they are already skipped for the creation/deletion events, when the diff is a full-body vs. None diff.

Skip patching the body essence if it is the same as the one already stored on the object. This pollutes the logs with difficult-to-read JSON dumps, especially on the resuming events — when these patches and logs contain no useful information.

Skip purging the handler progress if there is no progress stored (e.g. for one-handler cases, when it succeeds immediately). This produced unnecessary API patches, and polluted the logs for no good reason.

These changes will reduce the amount of meaningless logs produced.

Types of Changes

  • Refactor/improvements

Review

List of tasks the reviewer must do to review the PR

  • Tests

@nolar nolar added the enhancement New feature or request label Nov 15, 2019
@nolar nolar requested a review from samurang87 as a code owner November 15, 2019 10:44
@nolar nolar requested a review from aweller November 15, 2019 10:44
@zincr
Copy link

zincr bot commented Nov 15, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Nov 15, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

aweller
aweller previously approved these changes Nov 15, 2019
@nolar nolar merged commit ba2eaec into zalando-incubator:master Nov 15, 2019
@nolar nolar deleted the thrifty-essence-patches branch November 15, 2019 11:42
@nolar nolar changed the title Avoid meaningless logging of essence patches & empty diffs Avoid meaningless logging and patching Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants