This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less patching, less logging when not needed.
Description
Skip logging the empty diffs. They are useless. Especially on the resuming events, when the object is not changed actually. — As they are already skipped for the creation/deletion events, when the diff is a full-body vs.
None
diff.Skip patching the body essence if it is the same as the one already stored on the object. This pollutes the logs with difficult-to-read JSON dumps, especially on the resuming events — when these patches and logs contain no useful information.
Skip purging the handler progress if there is no progress stored (e.g. for one-handler cases, when it succeeds immediately). This produced unnecessary API patches, and polluted the logs for no good reason.
These changes will reduce the amount of meaningless logs produced.
Types of Changes
Review
List of tasks the reviewer must do to review the PR