This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Fix the stop-flag setting: no arguments are expected #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sadly so, in #147, an error sneaked into the code:
Event.set()
does not accept any arguments, but they are passed into a callback. The callback was originally implemented as a separate async-function, which took a list of tasks and cancelled all of them. Then, the callback was replaced to a flag-setting. But the argument with a list of tasks went unnoticed.This only affects the operators on its termination stage (Ctrl+C or pod deletion/restarting), and does not affect the behaviour itself.
Types of Changes