Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Fix the stop-flag setting: no arguments are expected #151

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Jul 15, 2019

Issue: #142, introduced in #147

Description

Sadly so, in #147, an error sneaked into the code:

Event.set() does not accept any arguments, but they are passed into a callback. The callback was originally implemented as a separate async-function, which took a list of tasks and cancelled all of them. Then, the callback was replaced to a flag-setting. But the argument with a list of tasks went unnoticed.

This only affects the operators on its termination stage (Ctrl+C or pod deletion/restarting), and does not affect the behaviour itself.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

@nolar nolar added the bug Something isn't working label Jul 15, 2019
@nolar nolar requested a review from samurang87 as a code owner July 15, 2019 20:07
@zincr
Copy link

zincr bot commented Jul 15, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Jul 15, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@codecov-io
Copy link

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files          30       30           
  Lines        1572     1572           
  Branches      229      229           
=======================================
  Hits         1298     1298           
  Misses        229      229           
  Partials       45       45
Impacted Files Coverage Δ
kopf/reactor/queueing.py 56% <0%> (ø) ⬆️

@nolar nolar merged commit ae57004 into zalando-incubator:master Jul 16, 2019
@nolar nolar deleted the fix-stop-flag-setting branch July 16, 2019 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants