Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cznic/golex by Ragel #80

Closed
z7zmey opened this issue Mar 18, 2019 · 1 comment
Closed

Replace cznic/golex by Ragel #80

z7zmey opened this issue Mar 18, 2019 · 1 comment

Comments

@z7zmey
Copy link
Owner

z7zmey commented Mar 18, 2019

Ragel generates a more performant lexer than cznic/golex
@z7zmey z7zmey mentioned this issue Mar 20, 2019
Closed
z7zmey added a commit that referenced this issue Mar 20, 2019
@z7zmey
#80 implement Ragel based lexer
2c64915
z7zmey added a commit that referenced this issue Mar 20, 2019
@z7zmey
Merge pull request #83 from z7zmey/ragel
b00a785 
#80 implement Ragel based lexer
@z7zmey z7zmey closed this as completed Mar 20, 2019
@z7zmey z7zmey mentioned this issue Jun 1, 2019
Closed
@quasilyte
Copy link
Contributor

quasilyte commented Apr 8, 2020 •
edited
Loading

For the historical reference, it seems like the performance boost is significant.

Benchmarks in php-parser repository show x2-3 speedup.

In a more real-case scenario that performance increase is lower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@z7zmey @quasilyte