Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dialog fixes so they do not block ui elements on top such as toasts #182

Merged
merged 1 commit into from
Aug 4, 2022
Merged

fix: dialog fixes so they do not block ui elements on top such as toasts #182

merged 1 commit into from
Aug 4, 2022

Conversation

zacgodinez
Copy link
Contributor

Description

FIx dialog issue so they render in mode modal=false.
this is needed to the the focus is not locked and users can click on toasts when they pop over the dialog

@zacgodinez zacgodinez added the bug Something isn't working label Aug 4, 2022
@zacgodinez zacgodinez requested a review from heathsnee August 4, 2022 10:04
@zacgodinez zacgodinez self-assigned this Aug 4, 2022
heathsnee
heathsnee approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@heathsnee heathsnee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@heathsnee heathsnee merged commit 908fb73 into develop Aug 4, 2022
@heathsnee heathsnee deleted the fix/toast-z-index branch August 4, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heathsnee heathsnee heathsnee approved these changes

Assignees

@zacgodinez zacgodinez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacgodinez @heathsnee