Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it possible to load:
Also it removes duplicate code in
ArtistItemsContinuationPage
.There is still room for optimization. For example in
ArtistItemsScreen
we now always call twoLaunchedEffect
(forlazyListState
andlazyGridState
).I don't know how much worse this is for performance.
We could do this conditionally but since I'm still learning and never used Compose before I'm not feeling confident yet doing changes in this part of the code.
Maybe someone else can work on that or I might open a separate draft PR for optimizations.
Also the initial loading placeholders are still not correct. For example when loading albums (displayed in a grid) it still initially shows list item placeholders (because it doesn't know yet that it should display a grid).
Looks a bit weird. But nothing new, this already happened before this PR so I would not change it here. Maybe something for later.