-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow age restricted songs to play by sending age check confirmation #1676
Conversation
…heck confirmation)
This does not seem to work anymore since you switched to the IOS client: Now I have to find out how this is done on IOS but I don't have an IOS device for testing. |
Just saw that ViTune also added this but in ViTune it is a |
@25huizengek1 what is the reason you made this |
@gechoto I actually can't recall, it was a really rushed debugging session in order to fix streaming for ViTune. During testing it didn't seem to matter though. |
@25huizengek1 how did you find all the values needed for the IOS client? Do you have a real IOS device for testing? @z-huang I currently can't get age restricted songs to work with the IOS client. Would it be okay as a quick fix to re-add the
|
It's okay. You can add it in this PR. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14305798 | Triggered | Google API Key | 93ac477 | innertube/src/main/java/com/zionhuang/innertube/models/YouTubeClient.kt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@z-huang done. I suggest to squash the commits on merge. |
@gechoto Since I don't own any Apple devices, I just tried different combinations of versions (or user agents) I found in the community: for example yt-dlp, https://github.com/zerodytrash/YouTube-Internal-Clients, NewPipeExtractor, etc. The rest of the values I got myself by just guessing from the traffic on desktop and Android. |
Before:
After:
This implements what the desktop/web player does when you click the button to confirm your age.
I guess you still need to be logged in for this to work. I haven't tested without login but it works with my account.
Maybe fixes #1442