-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to change app startup sections #1351
Add possibility to change app startup sections #1351
Conversation
…Vero-app-startup-sections-issue-1064 # Conflicts: # app/src/main/java/com/zionhuang/music/ui/screens/HomeScreen.kt
You can draw these switches with a "HOME SECTIONS" label, just like "PROXY" below. |
Got you, I'll add a label as soon as possible. |
…Vero-app-startup-sections-issue-1064
…Vero-app-startup-sections-issue-1064 # Conflicts: # app/src/main/java/com/zionhuang/music/ui/screens/HomeScreen.kt
If you disable all of these, your home screen will be empty. That doesn't look good. |
@z-huang I thought it was exactly what some users want. But if it's breaking UI, maybe it's a good idea to leave only the possibility of removing new releases. |
Or maybe an even better idea would be to add a label with something like "Enable sections in the Content settings" |
It's a UI/UX problem:
What if I add more sections in home screen and make "new albums" and "mood and genres" at the bottom? And why do you want to hide these sections? Fetching the data just need very few internet traffics. If you don't want to see it, you can ignore them. YouTube Music and Spotify (and more!) don't have the option to let you hide something off, but people are okay with it. They just find what they want to use and see. |
I've got you, it was just one of the open issues, so I took it. If now it's not needed - no problem. |
What about showing a dialog with 3 checkboxes? I mean if someone needs to tweak this screen, why not? I personally hate the new release albums and would use this feature to hide it. |
@nvllz Do you use quick picks? |
@z-huang Once in a while. Why? |
The home screen is revamped. New release and mood and genres are moved to the bottom. Are these settings still needed? |
Actually, I don't think it's needed. Closing. |
Each section on the Home screen can be added or removed (link to the issue - #1064)
![Screenshot_20240811-104147](https://private-user-images.githubusercontent.com/39765531/356865539-86505597-f535-4bb5-bb34-fcf578d11669.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTkwNzksIm5iZiI6MTczOTU5ODc3OSwicGF0aCI6Ii8zOTc2NTUzMS8zNTY4NjU1MzktODY1MDU1OTctZjUzNS00YmI1LWJiMzQtZmNmNTc4ZDExNjY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1NTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhYjI0YjQyMmI5OTBkZjljMjMzYjNhNjA0ZTBlMzAxMjRhMDY5N2NiMmE0MWExZWNiMmM2OWMwM2MxMTQzMTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wcNOFp-C41_Jc2cEis-HPM84wxdLliJYf77e-Qv84Z8)
![Screenshot_20240811-104203](https://private-user-images.githubusercontent.com/39765531/356865542-e663ed4f-6f09-48ec-90cf-f3ddd8212263.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTkwNzksIm5iZiI6MTczOTU5ODc3OSwicGF0aCI6Ii8zOTc2NTUzMS8zNTY4NjU1NDItZTY2M2VkNGYtNmYwOS00OGVjLTkwY2YtZjNkZGQ4MjEyMjYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1NTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFjMTZhYWE2ODUzYjk0Y2QwZDQ1Zjk3Yzk5ZWFmNTQ4ZGNlZGE0NGMzYzNiM2Y4ODdhZjRiOTQ1OTBkZGNjY2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fXMgs_rpjo6IDRQ3n8AhBsOk3b11FZiVjgaWtCVNlyQ)
![Screenshot_20240811-104214](https://private-user-images.githubusercontent.com/39765531/356865543-96f6e3c1-b9b5-4bf1-9e14-f69279d8114a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTkwNzksIm5iZiI6MTczOTU5ODc3OSwicGF0aCI6Ii8zOTc2NTUzMS8zNTY4NjU1NDMtOTZmNmUzYzEtYjliNS00YmYxLTllMTQtZjY5Mjc5ZDgxMTRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1NTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3YWJiYWMyZWVkOTI0OGIzMGZjODBjZWE1ZmNiODdkZWU2NjE4ZmIwNWJlOTRmN2U5ODliMDY5NTIwMzZmMmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QP0iS-fUeumhW7QzkRxUEsQjl3JZ9L_GciS2C7Tl2P0)
![Screenshot_20240811-104222](https://private-user-images.githubusercontent.com/39765531/356865544-d605b47c-ce90-43d9-adad-2a8b4310997e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTkwNzksIm5iZiI6MTczOTU5ODc3OSwicGF0aCI6Ii8zOTc2NTUzMS8zNTY4NjU1NDQtZDYwNWI0N2MtY2U5MC00M2Q5LWFkYWQtMmE4YjQzMTA5OTdlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1NTI1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU1N2YxYWU1NDI3MDMzMDJlMmFmYTQ0MTA2ZjcxZGM5M2ExZmUyZGJlMjA5NzVjYzZhODlmOTkyMGRlODIyZmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lmhN76MO006_mv5iNIUeZoV64nCXqbYx1FcOEzAsUAw)