Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to change app startup sections #1351

Conversation

AndreVero
Copy link

Each section on the Home screen can be added or removed (link to the issue - #1064)
Screenshot_20240811-104147
Screenshot_20240811-104203
Screenshot_20240811-104214
Screenshot_20240811-104222

…Vero-app-startup-sections-issue-1064

# Conflicts:
#	app/src/main/java/com/zionhuang/music/ui/screens/HomeScreen.kt
@nvllz
Copy link
Contributor

nvllz commented Aug 12, 2024

You can draw these switches with a "HOME SECTIONS" label, just like "PROXY" below.

@AndreVero
Copy link
Author

You can draw these switches with a "HOME SECTIONS" label, just like "PROXY" below.

Got you, I'll add a label as soon as possible.

@AndreVero
Copy link
Author

AndreVero commented Aug 13, 2024

You can draw these switches with a "HOME SECTIONS" label, just like "PROXY" below.

@nvllz @z-huang Added the "Home sections" label

…Vero-app-startup-sections-issue-1064

# Conflicts:
#	app/src/main/java/com/zionhuang/music/ui/screens/HomeScreen.kt
@z-huang
Copy link
Owner

z-huang commented Aug 14, 2024

If you disable all of these, your home screen will be empty. That doesn't look good.

@AndreVero
Copy link
Author

@z-huang I thought it was exactly what some users want. But if it's breaking UI, maybe it's a good idea to leave only the possibility of removing new releases.

@AndreVero
Copy link
Author

Or maybe an even better idea would be to add a label with something like "Enable sections in the Content settings"

@z-huang
Copy link
Owner

z-huang commented Aug 14, 2024

It's a UI/UX problem:

  • Content settings page becomes crowded
  • Home page becomes empty and tedious

What if I add more sections in home screen and make "new albums" and "mood and genres" at the bottom? And why do you want to hide these sections? Fetching the data just need very few internet traffics. If you don't want to see it, you can ignore them. YouTube Music and Spotify (and more!) don't have the option to let you hide something off, but people are okay with it. They just find what they want to use and see.

@AndreVero
Copy link
Author

I've got you, it was just one of the open issues, so I took it. If now it's not needed - no problem.

@nvllz
Copy link
Contributor

nvllz commented Aug 14, 2024

What about showing a dialog with 3 checkboxes? I mean if someone needs to tweak this screen, why not? I personally hate the new release albums and would use this feature to hide it.

@z-huang
Copy link
Owner

z-huang commented Aug 16, 2024

@nvllz Do you use quick picks?

@nvllz
Copy link
Contributor

nvllz commented Aug 16, 2024

@z-huang Once in a while. Why?

@z-huang
Copy link
Owner

z-huang commented Aug 23, 2024

The home screen is revamped. New release and mood and genres are moved to the bottom. Are these settings still needed?

@z-huang
Copy link
Owner

z-huang commented Aug 27, 2024

Actually, I don't think it's needed. Closing.

@z-huang z-huang closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants