Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions required to README.md #64

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Add permissions required to README.md #64

merged 5 commits into from
Oct 24, 2023

Conversation

francorbacho
Copy link
Contributor

This was pretty confusing to me, and it looks like obvious information to provide to new users.

@ggrossetie
Copy link
Member

I didn't know it was needed. Were did you configure this setting?

@francorbacho
Copy link
Contributor Author

It was failing for me (at least on private repos) with an authorization error without it. It was all configured in the job.yml file like so:

name: Foo

on:
  push:
  pull_request:

jobs:
  run-job:
    runs-on: ubuntu-latest
    permissions:
      contents: read
      checks: write
    steps:
      - ...

@ggrossetie
Copy link
Member

I found an explanation at: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

You are probably using a "restricted" GITHUB_TOKEN as mentioned in: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

I think we should explain when it's needed and why it's needed. As far as I understand, it's only needed when using a "restricted" GITHUB_TOKEN.

Do you have the authorization error message? It might also help others to troubleshoot if we copy/paste the error message next to the solution.

Thanks!

@francorbacho
Copy link
Contributor Author

I don't know why I have a restricted access GITHUB_TOKEN, I don't think I configured it anywhere.

Anyhow, I have included the information you requested. Feel free to rearrange the information as you wish.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ggrossetie
Copy link
Member

@francorbacho That's great, thank you! I made tiny updates. Thanks again for taking the time to help others 🤗

@ggrossetie ggrossetie merged commit dd44271 into yuzutech:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants