Skip to content

Commit

Permalink
Add OTLP JSON support for Kafka e2e Integration tests (jaegertracing#…
Browse files Browse the repository at this point in the history
…5935)

<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! πŸ‘‹πŸŽ‰
-->

## Which problem is this PR solving?
- <!-- Example: Resolves jaegertracing#123 --> This PR addresses the issue of
verifying Kafka e2e integration tests for otlp_json formats.

## Description of the changes
- Verified if the Kafka e2e integration tests run for otlp_json formats.
- Used a fork of mine
(github.com/joeyyy09/opentelemetry-collector-contrib) to incorporate
necessary changes and verify the process.

## How was this change tested?
- Ran the Kafka e2e integration tests locally using the modified
configuration.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: joeyyy09 <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
  • Loading branch information
joeyyy09 and yurishkuro authored Oct 23, 2024
1 parent 9eaa882 commit fcb6ba2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/integration/kafka_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func TestKafkaStorage(t *testing.T) {
skip string
}{
{encoding: "otlp_proto"},
{encoding: "otlp_json", skip: "not supported: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/33627"},
{encoding: "otlp_json"},
{encoding: "jaeger_proto"},
{encoding: "jaeger_json"},
}
Expand Down

0 comments on commit fcb6ba2

Please sign in to comment.