Remove the default value of response data

yunnysunny · Jul 15, 2020 · 21f5793 · 21f5793
1 parent ce03a0c
commit 21f5793
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# v0.12.1
+## Remove
+1. Remove the default value of response data. You should avoid reading undefined object in `dataFormat` function when format response data.
+
 # v0.12.0
 ## Add
 1. Add the field of `res_data`, which contains the reponse data.

diff --git a/index.js b/index.js
@@ -65,7 +65,7 @@ module.exports = function({
             const req_data = dataFormat(req_data_original);
             const referer = req.get('referer') || '';
             const session = req.session;
-            const res_data = dataFormat(res._res_data || {}, true);
+            const res_data = dataFormat(res._res_data, true);
 
             if (kafkaSchedule || mongooseModel) {
                 const custom_headers = {};

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@yunnysunny/request-logging",
-  "version": "0.12.0",
+  "version": "0.12.1",
   "description": "Print the express request log to console and save it to kafka when required, and even can send alram message when the response code greater than 500.",
   "main": "index.js",
   "scripts": {

diff --git a/test/express/src/app-with-format.js b/test/express/src/app-with-format.js
@@ -22,7 +22,10 @@ app.set('port', port);
 app.use(requestLog({
     mongooseModel:requestLogModel,
     customHeaderKeys: [CUSTOM_HEADER_KEY_MY_ID],
-    dataFormat: function(data) {
+    dataFormat: function(data, isFromRes) {
+        if (isFromRes) {
+            return;
+        }
         data[TO_FORMAT_FIELD] = (data[TO_FORMAT_FIELD] || '') + FORMAT_SUFFIX;
         return data;
     }