Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Set hostname as well when creating an instance #156

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

nevill
Copy link
Contributor

@nevill nevill commented Sep 11, 2018

There is a parameter named hostname when calling API RunInstances.

I'd like to have it set as well when creating instances in Terraform.
For example:

resource "qingcloud_instance" "gateway" {
  name             = "gateway"
  image_id         = "centos75x64"
  keypair_ids      = ["keypair_id"]
  managed_vxnet_id = "vxnet_id"
}

Will create an instance named gateway, but its hostname is i-xxxxx.
It should set instance hostname as gateway as well, same behavior as calling RunInstances with parameter hostname.

@runzexia
Copy link
Contributor

LGTM

@runzexia runzexia merged commit a614d45 into yunify:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants