Error type の jsonDecodeError 削除漏れを削除 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daichikuwa0618
approved these changes
Apr 14, 2021
| @@ -129,7 +129,6 @@ YumemiWeatherError | |||
| ```swift | |||
| public enum YumemiWeatherError: Swift.Error { | |||
| case invalidParameterError | |||
| case jsonDecodeError | |||
There was a problem hiding this comment.
[MEMO]
grep してみたところ
にも
jsonDecodeError があるが、こちらはアプリ内で定義した WeatherError エラーの 1 case なので問題無さそう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
対応
問題なさそうだったので PR を作らせていただきました。問題ありそうでしたらクローズしちゃってください 🙏