Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Session 12] ExampleのxcodeprojがBuildできない問題を修正 #11

Merged
merged 2 commits into from
Apr 26, 2021
Merged

[Session 12] ExampleのxcodeprojがBuildできない問題を修正 #11

merged 2 commits into from
Apr 26, 2021

Conversation

shimastripe
Copy link
Contributor

WHY

WHAT

課題自体で提示されている不具合とは別件と解釈してPRを出しました。
もし意図が誤っていたらCloseしてください 🙏

watanavex
watanavex approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@watanavex watanavex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おっしゃる通りの対応漏れと、スクリプトの修正ありがとうございます！

LGTM

@watanavex watanavex merged commit f0d6b45 into yumemi-inc:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watanavex watanavex watanavex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shimastripe @watanavex