Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to be independent of the args package #152

Merged
merged 14 commits into from
Jan 27, 2025

Conversation

masa-futa
Copy link
Contributor

Issue

Note

This PR will be the last package to be deleted in this issue,
so the issue will be automatically closed once the changes are merged.

Overview (Required)

args was used to parse command line arguments.
To eliminate the dependency, I manually rewrote it to the yumemi_lints specifications, referring to the internal structure of args.

Important

With this change, only the update option is accepted.
Specifying any other option will result in an exception.
There was some discussion about the help command, but it was deemed not important for yumemi_lints, so it has not been included in this PR.
Also, if there are no options, processing will proceed as usual.
These are guaranteed by the unit test system.

Links

Confirm

  • I verified that all tests were successful.
  • All static analyses were confirmed to be successful.
  • I manually verified everything that was being done by the unit tests.

Copy link
Contributor

Ready for review 🚀

@masa-futa
Copy link
Contributor Author

memo-badge
I tried to implement it with extensibility in mind,
but even if more commands are added in the future, it will only be a few commands,
and I wanted to keep the implementation simple, so I removed all the extension classes.
Existing functions are guaranteed.
f028c80
978f66d

Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masa-futa
Thank you for submitting the pull request. I’ve left a few comments, so please review them and make any necessary changes.

@masa-futa masa-futa requested a review from blendthink January 26, 2025 23:43
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masa-futa
I’ve left a few comments. Please take a look.

@masa-futa
Copy link
Contributor Author

@blendthink
Thank you for pointing that out!

"Method name changes / non-null support"

This has been fixed!
Please check again.🙏

@masa-futa masa-futa requested a review from blendthink January 27, 2025 00:30
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masa-futa
LGTM!

@masa-futa masa-futa merged commit 556a096 into main Jan 27, 2025
1 check passed
@masa-futa masa-futa deleted the improve/remove-args-package branch January 27, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve]: Remove packages from dependencies in yumemi_lints
2 participants