-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to be independent of the args package #152
Conversation
Ready for review 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masa-futa
Thank you for submitting the pull request. I’ve left a few comments, so please review them and make any necessary changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masa-futa
I’ve left a few comments. Please take a look.
@blendthink "Method name changes / non-null support" This has been fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masa-futa
LGTM!
Issue
Note
This PR will be the last package to be deleted in this issue,
so the issue will be automatically closed once the changes are merged.
Overview (Required)
args
was used to parse command line arguments.To eliminate the dependency, I manually rewrote it to the
yumemi_lints
specifications, referring to the internal structure ofargs
.Important
With this change, only the
update
option is accepted.Specifying any other option will result in an exception.
There was some discussion about the
help
command, but it was deemed not important foryumemi_lints
, so it has not been included in this PR.Also, if there are no options, processing will proceed as usual.
These are guaranteed by the unit test system.
Links
Confirm