fix: Version String Format Change Fix #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version string parsing logic to handle new format in rules.json where sinceDartSdk field changed from "major.minor.patch" (e.g. "2.2.0") to "major.minor" format (e.g. "2.2").
…ing parsing logic
github-actions
bot
requested review from
K9i-0,
morikann,
trm11tkr,
Yamasaki-pan961 and
YumNumm
|
Ready for review 🚀 |
blendthink
requested review from
masa-futa
and removed request for
Yamasaki-pan961,
morikann,
YumNumm,
trm11tkr and
K9i-0
masa-futa
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thank you for the great improvements!!
So it was a problem with sinceDartSdk. It was a blind spot for me.
All the workarounds seemed fine, so I accepted them!! 🙌
(It might be a good idea to raise an issue with pub_semver, since I'm sure there are at least a few people with the same problem.🤔)
|
|
||
| - Removed lint rules as they are now marked as "removed" in the upstream Dart SDK [dart-lang/sdk/pkg/linter/tool/machine/rules.json@762a4c7]. This is an intentional change as these rules have been officially deprecated: | ||
| - `package_api_docs` | ||
| - `unsafe_html` |
| // NOTE: | ||
| // This is a workaround for the fact that the `sinceDartSdk` field in the [rules.json] is not always a valid version. | ||
| // Expected format: "1.0", "2.1", etc. | ||
| // Unexpected format examples: "3.3-wip", "3.5-dev", etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
This PR addresses the issue where lint rules were not being generated correctly due to a format change in the version strings from "major.minor.patch" (e.g., "2.2.0") to "major.minor" (e.g., "2.2") in the source data.
Changes
Important Notes
package_api_docsandunsafe_html) were removed from the generated output. Due to these breaking changes, we plan to hold off on releasing until Issue #138 is resolved.Scope
This PR specifically focuses on the version string parsing fix. Updates for the latest Dart/Flutter lint rules will be discussed and handled separately to keep the changes focused and manageable.
Links
Screenshot
N/A