Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to be independent of the pub_semver package #141

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

blendthink
Copy link
Member

@blendthink blendthink commented Sep 19, 2024

Issue

Overview (Required)

The pub_semver package was introduced to parse Dart and Flutter versions and to handle and compare only the Major and Minor versions for display. I implemented that part independently and removed the pub_semver package.

Links

Screenshot

2024-09-24.11.14.12.mov

@blendthink blendthink marked this pull request as ready for review September 24, 2024 02:15
Copy link
Contributor

Ready for review 🚀

Base automatically changed from improve/remove-meta-package to main January 7, 2025 08:59
@blendthink blendthink enabled auto-merge January 7, 2025 08:59
Copy link
Contributor

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a minor point, I've made one comment for your review. Please check it.
The other parts of the code look good. Thank you!

packages/yumemi_lints/lib/src/models/version.dart Outdated Show resolved Hide resolved
@blendthink blendthink requested a review from morikann January 9, 2025 03:34
Copy link
Contributor

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@blendthink blendthink merged commit 0ff7095 into main Jan 10, 2025
1 check passed
@blendthink blendthink deleted the improve/remove-pub_semver-package branch January 10, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants